Skip to content

fix(insights): hide copy strategy text on mobile#498

Merged
aldin4u merged 3 commits intostagingfrom
feat/mobile-copy-button-fix
Jan 20, 2026
Merged

fix(insights): hide copy strategy text on mobile#498
aldin4u merged 3 commits intostagingfrom
feat/mobile-copy-button-fix

Conversation

@aldin4u
Copy link
Collaborator

@aldin4u aldin4u commented Jan 20, 2026 •
edited by coderabbitai bot
Loading

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Style
    • Improved mobile responsiveness: the copy button now hides its text on small screens while keeping the icon visible, preserving the same copy functionality and experience on larger screens.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 20, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

Two small UI/formatting edits: the "Copy Strategy" button label in SignalCard is now conditionally hidden on small screens via a responsive span; PerpsTile JSX attributes and an inline SVG were compacted from multi-line to single-line formatting. No logic or behavioral changes.

Changes

Cohort / File(s) Summary
Responsive UI change
src/apps/insights/components/SignalCard/SignalCard.tsx		 Wrapped the "Copy Strategy" label in a <span> with hidden md:inline so the text is hidden on small screens while the icon remains visible.
JSX formatting
src/apps/pillarx-app/components/PerpsTile/PerpsTile.tsx		 Consolidated multi-line JSX attributes (button and embedded SVG) into single-line elements; no functional changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • vignesha22
  • RanaBug
  • IAmKio

Poem

🐰 A little tweak, nimble and spry,
Text hides on phones while icons stay nigh.
Lines tightened up, tidy and bright,
Copy the strategy — hop into the night! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty with only template placeholders, lacking any implementation details, testing information, or type classification. Complete all required sections: add a detailed description of changes, document testing steps and environment, select the appropriate change type (bug fix), and include screenshots if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: hiding the 'Copy Strategy' text on mobile screens via responsive CSS classes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Jan 20, 2026
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/apps/insights/components/SignalCard/SignalCard.tsx (1)

138-151: Add an accessible name for the icon-only button on mobile.

With the label hidden on small screens, the button risks having no accessible name. Add aria-label (or an sr-only span) so screen readers still announce the action.

♿️ Suggested fix 
-              <button
+              <button
                 onClick={copyStrategy}
                 className="flex items-center gap-1.5 px-3 py-1.5 rounded-lg border border-white/20 transition-all duration-200 text-xs font-medium text-white"
+                aria-label="Copy Strategy"
               >

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2026 •
edited
Loading

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7cbd020
Status: ✅  Deploy successful!
Preview URL: https://900a2016.x-e62.pages.dev
Branch Preview URL: https://feat-mobile-copy-button-fix.x-e62.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 20, 2026 •
edited
Loading

Deploying pillarx-debug with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7cbd020
Status: ✅  Deploy successful!
Preview URL: https://e9a6ef05.pillarx-debug.pages.dev
Branch Preview URL: https://feat-mobile-copy-button-fix.pillarx-debug.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (feat/mobile-copy-button-fix) January 20, 2026 23:28 Inactive
@aldin4u aldin4u merged commit 482b563 into staging Jan 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@aldin4u